forked from moneybutton/bips
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bnb #6
Open
Akrom17
wants to merge
3,378
commits into
bitcoin-sv-specs:2015_12_bip1
Choose a base branch
from
bitcoin:master
base: 2015_12_bip1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
bnb #6
+59,793
−1,034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions BIP 337: Compressed Transactions
BIP431: Opt In Topologically Restricted Until Confirmation Transactions For More Robust Fee-bumping
Fix typos on 17 files.
Remove duplicated words
bip-0322: add another valid sig vector not to confuse
User behavior has clearly indicated a strong demand for the resolution of human-readable names into payment instructions. This BIP defines a protocol to do so using only the DNS, providing for the ability to query such resolutions privately, while utilizing DNSSEC to provide compact and simple to verify proofs of mappings.
To fix the merge conflict caused by BIP 47 getting updated to final.
BIP79: remove repeat word
…tions Add BIP 353: DNS Payment Instructions
BIP340: remove repeat words
Fix bip number in specification
[BIP-0349] OP_INTERNALKEY add credit section
…ft_x BIP-340: fix `lift_x` calls in test vector generation script
Update bip-0370.mediawiki
Co-authored-by: Mark "Murch" Erhardt <[email protected]>
Co-authored-by: Mark "Murch" Erhardt <[email protected]>
[BIP-0349] Add Re-Keying explanation to OP_INTERNALKEY
BIP374: Discrete Log Equality Proofs (DLEQ)
BIP374: Fix link and formatting in reference section
Both generating and verifying a proof allows for specifying a custom generator point G. But that custom generator point was not passed into the dleq_challenge function, resulting in the default (secp256k1) generator point to be used. This lead to the test vectors being incorrect.
To avoid the mistake fixed in the previous commit, we remove the default value from the G parameter of dleq_challenge.
bip-0374: fix challenge generation, use correct generator point
BIP-374: add generated test vector .csv files
…es-executable BIP374: update reference.py and secp256k1.py to be executable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
off mistery